Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFLint JAR became 22MB again #420

Closed
ryaneberly opened this issue Aug 11, 2017 · 2 comments
Closed

CFLint JAR became 22MB again #420

ryaneberly opened this issue Aug 11, 2017 · 2 comments
Assignees
@denuno
Labels
bug
Milestone
1.2.3

Comments

@ryaneberly
Copy link
Contributor

michal.paluchowski [4 hours ago]
only the runtime is needed after the antlr Maven plugin runs

michal.paluchowski [4 hours ago]
the full antlr includes com.ibm.icu:icu4j:jar:58.2 in its dependencies, which adds a whopping 12MB to the final JAR size

michal.paluchowski [4 hours ago]
the full antlr dependency was only needed in tests, hence the dependency in test scope

michal.paluchowski [3 hours ago]
plus, cfparser depends on both runtime 4 and 3, because there's both code using one or the other present
@TheRealAgentK
Copy link
Collaborator

I wonder if @ryaneberly could fix it quickly and we push out a 1.2.3 (and also fix the issue with the wrong version number inside of 1.2.1)?

@TheRealAgentK
Copy link
Collaborator

Solved in CFlint release 1.2.3

@TheRealAgentK TheRealAgentK added this to the 1.2.3 milestone Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denuno denuno

Labels
bug
Projects
None yet
Milestone
1.2.3
Development

No branches or pull requests
3 participants
@denuno @TheRealAgentK @ryaneberly