-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subroutine COSP_OPAQ declares surfelev as optional #27
Comments
@brhillman |
@dustinswales @brhillman |
@dustinswales @brhillman |
Oh, apologies, I might have had to add the optional to get it to run, because it's optional in |
@brhillman @rodrigoguzman-lmd @RobertPincus After going through the code, I vote to keep |
@dustinswales Your logic is sound. Does it imply we should see if @brhillman is willing to open a PR with changes to protect against using the variable when it's not provided? |
@RobertPincus |
Closed. |
Subroutine
COSP_OPAQ
declares input variablesurfelev
asoptional
, but it is used throughout the routine as if it is always present. This causes a segfault when using the Intel compiler ifsurfelev
is not passed to the routine. My guess is thatsurfelev
probably should not be optional at all, but if this is the desired interface then simply wrapping code that uses it in a logical that checks for the presence ofsurfelev
would be sufficient. For example, at line 1429 inlidar_simulator.F90
, the following could be used as a fix:and likewise in other spots in the code that use
surfelev
.The text was updated successfully, but these errors were encountered: