Post Django errors to Github #3322
Conversation
cfgov/alerts/post_django_errors.py
Outdated
| @@ -0,0 +1,14 @@ | |||
| import logging | |||
There was a problem hiding this comment.
I think the naming of the post_django_errors.py file might want to be more consistent with other logging handler module names since it's just a Python logging handler, not Django-specific.
richaagarwal
force-pushed
the
post-django-errors
branch
2 times, most recently
from
327af08
to
18404b8
Compare
richaagarwal
force-pushed
the
post-django-errors
branch
from
cdc421c
to
7746d59
Compare
cfgov/alerts/logging_handlers.py
Outdated
|
|
||
| def emit(self, record): | ||
| GithubAlert({}).post( | ||
| title=record.message[:30], |
There was a problem hiding this comment.
Truncating to 30 characters isn't ideal but I'm not sure how else to do this for now. Curious to see it in action before optimizing this.
|
@willbarton Ready for review again |
cfgov/alerts/logging_handlers.py
Outdated
|
|
||
| class CFGovErrorHandler(logging.Handler): | ||
| def __init__(self): | ||
| logging.Handler.__init__(self) |
There was a problem hiding this comment.
Why is this __init__ necessary, if it all it does is call the base class?
| """ Test that calling CFGOVErrorHandler.emit | ||
| makes a GithubAlert post with the right parameters | ||
| """ | ||
| message = ('Internal Server Error: /tést-page/' |
There was a problem hiding this comment.
Did you mean to define this as a unicode string, e.g. u'/tést-page/' vs '/tést-page/'? Might be nice to have a from __future__ import unicode_literals here.
| @@ -41,6 +41,10 @@ | |||
| 'level': 'DEBUG', | |||
| 'class': 'logging.StreamHandler', | |||
| }, | |||
| 'db': { | |||
There was a problem hiding this comment.
Not sure if you want to test this config, but one way of doing it might be to use the built-in django.test.utils.patch_logger as demonstrated here.
richaagarwal
force-pushed
the
post-django-errors
branch
from
7746d59
to
33bb7e3
Compare
|
I'm merging this @willbarton. We can iterate! |
ERROR