Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing closing div tag around Related Posts in sidefoot #5690

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

Scotchester
Copy link
Contributor

@Scotchester Scotchester commented Apr 28, 2020

My bad: https://github.com/cfpb/cfgov-refresh/pull/4622/files#r416953702

Additions

  • Re-adds accidentally removed closing </div> tag after including the Related Posts module in a sidefoot

Testing

  1. Go to https://validator.w3.org/#validate_by_uri
  2. Validate a page like https://www.consumerfinance.gov/about-us/blog/avoid-scams-find-help-during-quarantine/
  3. Observe these errors toward the bottom of the list:
    snippet of validation results showing two errors: "End tag aside seen, but there were open elements" and "Unclosed element div"
  4. Pull branch
  5. Load up http://localhost:8000/about-us/blog/avoid-scams-find-help-during-quarantine/
  6. View source and copy it all
  7. Go to https://validator.w3.org/#validate_by_input
  8. Paste the source into the field and validate it
  9. See that the aforementioned errors are not returned

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool 鉃★笍

@Scotchester Scotchester requested review from chosak and a team April 28, 2020 22:17
@Scotchester Scotchester merged commit 49e8e37 into master Apr 29, 2020
@Scotchester Scotchester deleted the fix-missing-tag branch April 29, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants