Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Search: Fix cropped search focus rectangle #5710

Merged
merged 1 commit into from
May 6, 2020
Merged

Global Search: Fix cropped search focus rectangle #5710

merged 1 commit into from
May 6, 2020

Conversation

anselmbradford
Copy link
Member

I've had enough of looking at this issue, and turns out it's an easy fix!

Changes

  • Fix cropped search focus rectangle.

Testing

  1. Pull branch and build.
  2. Click into the global search and see that the focus rectangle is not cropped on the left-hand side. Compare to production.

Screenshots

Before:
Screen Shot 2020-05-06 at 5 05 55 PM

After:
Screen Shot 2020-05-06 at 5 05 46 PM

@anselmbradford anselmbradford requested review from Scotchester, contolini and a team May 6, 2020 21:08
Scotchester
Scotchester approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anselmbradford, the hero we need.

@anselmbradford anselmbradford merged commit 9f8a0f0 into master May 6, 2020
@anselmbradford anselmbradford deleted the ans_fix_search_focus branch May 6, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scotchester Scotchester Scotchester approved these changes

@contolini contolini Awaiting requested review from contolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anselmbradford @Scotchester