Make interpretation location a variable in iRegs #5716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding inline interpretations to Regulation D. Unlike all of our other regs, Reg D houses its interpretations in Appendix A instead of Supplement I. We had "Supplement I" hardcoded into the text of the links at the end of all inline interpretations, which didn't make sense for inline interps in Reg D. This PR fixes that by making the reference to the location of the interps in those links a variable and sets up a special case for Reg D interps.
Changes
Testing
Screenshots
Notes
@willbarton and I were chatting about this one, and we both agree that hardcoding a special case for Reg D in the
inline_interp
template isn't the best way to handle this. A much better way would be to make the location of each inline interp available as a context variable in the template instead. But that's a much tricker change that needs some more thought, so we agreed to go with this change in the template for now.Checklist
Testing checklist
Browsers
Accessibility
Other