Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Apache configuration preventing prepaid-cards section from being cached #5740

Merged
merged 1 commit into from
May 20, 2020

Conversation

Scotchester
Copy link
Contributor

@Scotchester Scotchester commented May 20, 2020

We can't recall why we would have done that, and can't think of a good reason to still be doing it.

Removals

  • Apache configuration directive setting the Edge-Control: no-store header for /consumer-tools/prepaid-cards/ and its children

Changes

  • Makes comment that preceded that a little more explicit

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the CFPB development guidelines
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool 鉃★笍

We can't recall why we would have done that, and can't think of a good reason to still be doing it.
@Scotchester Scotchester requested a review from chosak May 20, 2020 13:49
@Scotchester Scotchester merged commit 9cb025e into master May 20, 2020
@Scotchester Scotchester deleted the rm-prepaid-cache-blocking branch May 20, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants