Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables: Fix striped tables #5763

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Tables: Fix striped tables #5763

merged 2 commits into from
Jun 3, 2020

Conversation

niqjohnson
Copy link
Member

Striped tables weren't actually getting striped because of a slightly wrong class getting applied.

Changes

  • The table__striped class that was being applied to striped tables is now the correct o-table__striped

How to test this PR

  1. Add a table to a page in Wagtail and check the "striped rows" option.
  2. Preview that table and make sure the table is striped as shown in the Design System.

Screenshots

striped-table

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases,
      so good ones make that easier to scan.
    • Consider prefixing with the feature/section you're addressing,
      e.g., "Mega Menu: fix layout bug" or "Paying for College: Update content on Repay tool"
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

Striped tables weren't actually getting striped because of a slightly wrong
class getting applied.
@niqjohnson niqjohnson requested a review from a team June 3, 2020 21:29
@niqjohnson niqjohnson merged commit f56d9fc into master Jun 3, 2020
@niqjohnson niqjohnson deleted the fix-stripes branch June 3, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants