Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app assets npm caches #5775

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Update app assets npm caches #5775

merged 2 commits into from
Jun 10, 2020

Conversation

anselmbradford
Copy link
Member

The app assets have some out of date/missing dependencies that are updated when the caches are re-generated.

Changes

  • Update app assets npm caches.

How to test this PR

  1. Site should work as before. There are some minor bumps happening in ccdb-landing maybe @sephcoster might want to look at?

@anselmbradford anselmbradford requested a review from a team June 9, 2020 21:11
wpears
wpears approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending seph's go-ahead

sephcoster
sephcoster approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@sephcoster sephcoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anselmbradford anselmbradford merged commit 8c303d5 into master Jun 10, 2020
@anselmbradford anselmbradford deleted the ans_update_app_asset_caches branch June 10, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sephcoster sephcoster sephcoster approved these changes

@wpears wpears wpears approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anselmbradford @sephcoster @wpears