Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Input - Hover - Define state styling (Success/Warning/Error status) #1881

Closed
natalia-fitzgerald opened this issue Jan 17, 2024 · 7 comments · Fixed by #1886
Closed

Text Input - Hover - Define state styling (Success/Warning/Error status) #1881

natalia-fitzgerald opened this issue Jan 17, 2024 · 7 comments · Fixed by #1886
Assignees
Labels
Size: 2 Est. level of effort: 1=tiny, 5=enormous

Comments

@natalia-fitzgerald
Copy link
Contributor

natalia-fitzgerald commented Jan 17, 2024

As part of the React component library (and lending app) we are currently looking to nail down the state styling for text input (Error status).

In the Design System we currently define the states as follows:

This is not visualized on the documentation page but is in the code. The hover state is Pacific while the other states are red. I am not sure whether this is intentional or a default style that was never customized for the error status.
Screenshot 2024-01-17 at 2 09 26 PM

If we apply the same visual logic that we do for the "destructive link" we could go with a dark red on hover.

That would look like this. What do you think?
Screenshot 2024-01-17 at 3 15 54 PM

I cross-referenced USWDS and they don't appear to have a separate hover style for their text inputs.

Default
Screenshot 2024-01-17 at 4 11 50 PM

Hover (No change)
The only change here is a cursor change.
Screenshot 2024-01-17 at 4 11 50 PM

Focus
Screenshot 2024-01-17 at 4 11 45 PM

@sonnakim for guidance

@natalia-fitzgerald natalia-fitzgerald self-assigned this Jan 17, 2024
@sonnakim
Copy link
Member

sonnakim commented Jan 17, 2024

@natalia-fitzgerald 👍 to adding a hover state for fields in error status, as shown above, and (as we discussed) to do likewise for checkboxes. (If this isn't added, a field in error status will show our default blue hover state.) @anselmbradford for awareness. (ETA: Natalia will also add hover states for success and warning, see comment below)

@natalia-fitzgerald
Copy link
Contributor Author

Ok, to confirm here are the colors for the hover states:

I don't have a use case for hover on success or warning in the work I'm doing but since the code currently defines these hover states as Pacific I recommend updating Success and Warning for the sake of consistent logic.

Success

  • Dark green: #1e9642

Warning

  • Dark gold: #dc731c

Error

  • Dark red: #b63014

@natalia-fitzgerald natalia-fitzgerald changed the title State styling for text input (Error status) Define state styling for text input (Error status) Jan 17, 2024
@itsmedavep
Copy link

itsmedavep commented Jan 17, 2024

I have made these changes to the Figma DS library file on a branch here.

@natalia-fitzgerald @sonnakim and @jenn-franklin

If you like I can merge the branch and publish the changes to the file after a review. Just let me know.

@natalia-fitzgerald
Copy link
Contributor Author

@itsmedavep
I reviewed and the the Figma file looks good.

@shindigira shindigira added the Size: 2 Est. level of effort: 1=tiny, 5=enormous label Jan 18, 2024
@itsmedavep
Copy link

I merged the changes and republished. TY everyone!

@shindigira shindigira changed the title Define state styling for text input (Error status) Define state styling for text input (Success/Warning/Error status) Jan 18, 2024
@shindigira shindigira changed the title Define state styling for text input (Success/Warning/Error status) Text Input - Hover - Define state styling (Success/Warning/Error status) Jan 18, 2024
@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Feb 29, 2024

I think this is completed @shindigira? Just still waiting on review?

@shindigira
Copy link
Contributor

I think this is completed @shindigira? Just still waiting on review?

Yes, need a final approval from @natalia-fitzgerald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 2 Est. level of effort: 1=tiny, 5=enormous
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants