Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits from Riad #107

Closed
chris-wood opened this issue Jun 3, 2020 · 1 comment
Closed

Nits from Riad #107

chris-wood opened this issue Jun 3, 2020 · 1 comment

Comments

@chris-wood
Copy link
Collaborator

chris-wood commented Jun 3, 2020

  • Section 5.1.3: it would be nice to include a reference or citation for
    unknown key share attacks.

  • Section 5.2: is there a reason to put the word "amortize" in quotes?

  • Section 7.1.2: it might be worth mentioning here that [keyagreement] also
    includes checking that the public key is not the identity point.

  • Section 7.1.2: is there a reason to recommend either checking for a nonzero
    scalar or checking for a non-identity DH output? Checking the latter covers
    the former and also covers the check from my prior comment. Moreover, it is
    not clear to me that checking the scalar is useful for the recipient, since
    this is essentially just checking that their long-term secret is nonzero.

  • Section 8.1: the sentence "In particular, the KDFs and DH groups..." might
    want to clarify that this statement is true only when these primitives are
    used as specified. The concern is that HKDF is only indifferentiable under
    some restrictions on salt length (for reasons noted in Section 8.3).

@chris-wood
Copy link
Collaborator Author

Fixed in #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant