Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try/catch instead of catchError #887

Closed
themightychris opened this issue Aug 6, 2020 · 17 comments
Closed

Use try/catch instead of catchError #887

themightychris opened this issue Aug 6, 2020 · 17 comments

Comments

@themightychris
Copy link

See Dart-Code/Dart-Code#2701 and dart-lang/linter#2212

@stale
Copy link

stale bot commented Sep 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Sep 5, 2020
@themightychris
Copy link
Author

themightychris commented Sep 6, 2020

this is still an issue that makes interactively debugging a Flutter app that uses Dio unpleasant

@stale stale bot removed the stale label Sep 6, 2020
@stale
Copy link

stale bot commented Oct 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Oct 10, 2020
@jmealo
Copy link

jmealo commented Oct 10, 2020

This is still an issue.

@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Nov 9, 2020
@ryon
Copy link

ryon commented Nov 9, 2020

Still an issue

@stale stale bot removed the stale label Nov 9, 2020
@stale
Copy link

stale bot commented Dec 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Dec 11, 2020
@themightychris
Copy link
Author

not stale, still driving flutter devs nuts on the daily

@stale stale bot removed the stale label Dec 11, 2020
@stale
Copy link

stale bot commented Jan 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2021
@ryon
Copy link

ryon commented Jan 10, 2021

Yes, this is still an issue

@stale stale bot removed the stale label Jan 10, 2021
@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2021
@jmealo
Copy link

jmealo commented Jun 19, 2021

Yes, this is still still an issue.

@stale stale bot closed this as completed Jun 26, 2021
@themightychris
Copy link
Author

common stalebot

@HE-LU
Copy link

HE-LU commented Nov 7, 2023

This is still and issue!

@AlexV525
Copy link
Member

AlexV525 commented Nov 7, 2023

@DanTup Are the mentioned issues still effective? In dart-lang/linter#2212 (comment) you said the original reason has been resolved.

@DanTup
Copy link

DanTup commented Nov 7, 2023

My understanding is that the fixes in dart-lang/sdk#37953 mean this is not necessary. When the issue was opened, the debugger did not understand that .catchError() was handling the exception, so the debugger would treat it as "uncaught". This is no longer the case.

There may still be some places where the debugger isn't correctly considering exceptions caught though (like dart-lang/sdk#47985) so this fix doesn't necessarily mean all related issues are solved (but those that still exist should have issues raised with clear example code to repro).

@AlexV525
Copy link
Member

AlexV525 commented Nov 7, 2023

This is no longer the case.

@DanTup Thanks!

Given the above fact, we no longer treat this issue as unresolved. Please submit new tickets if there are specific cases that can be handled better.

@cfug cfug locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants