Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes handling of column defaults on insert #681

Merged
merged 5 commits into from Nov 28, 2016

Conversation

andybellenie
Copy link
Contributor

No description provided.

@perdjurner
Copy link
Contributor

Thanks, I'll merge this as soon as I've fixed the test suite in the master branch.

@perdjurner
Copy link
Contributor

Can you include a test for this before I merge?

I feel like this is something that could easily be broken by later commits. Would be good to have a test to prevent that from happening.

@perdjurner
Copy link
Contributor

I think you need to pull in the latest populate.cfm to your repo (we just changed it today).

# Conflicts:
#	wheels/tests/populate.cfm
@perdjurner perdjurner merged commit 542b459 into cfwheels:master Nov 28, 2016
@perdjurner
Copy link
Contributor

Oops, looks like something failed after all.

@andybellenie, can you have a look and see if you know what it could be?

Here is a link to the server it fails on:
http://zebrinny.viviotech.net:8510/index.cfm?controller=wheels&action=wheels&view=tests&type=core

Thanks.

@andybellenie
Copy link
Contributor Author

It looks like some Oracle issues. I reverted my copy of Wheels back to the last commit before I made any changes (814e3c3) and ran the tests on Oracle on my local box and got the same broken tests so it doesn't seem to be anything to do with the new code.

@perdjurner
Copy link
Contributor

@neokoenig Any thoughts on this?

@neokoenig
Copy link
Contributor

I kicked zebrinny hard up the backside. Tests appear to pass now. I hate that server.

@perdjurner
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants