Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in onMissingTemplate (Lucee) #884

Open
andybellenie opened this issue Aug 7, 2018 · 3 comments
Open

Bug in onMissingTemplate (Lucee) #884

andybellenie opened this issue Aug 7, 2018 · 3 comments
Assignees
Milestone

Comments

@andybellenie
Copy link
Contributor

See https://luceeserver.atlassian.net/browse/LDEV-1946

A cfwheels app on lucee will throw errors when browsing to non-existing cfm templates. It's not a commonly seen issue because of the URL rewriting.

I've fixed it on one site (1.4.5) by modifying /wheels/events/onmissingtemplate.cfm to the following...

<cffunction name="onMissingTemplate" returntype="void" access="public" output="true">
	<cfargument name="targetpage" type="any" required="true">
	<cfheader statuscode="404" statustext="Page Not Found">
	<cfinclude template="../../events/onmissingtemplate.cfm">
</cffunction>

... but I'm not sure what the locking is for in this part of the code. Just removing abort; doesn't work, the error goes away but no output is rendered at all.

@andybellenie
Copy link
Contributor Author

It only works when I output the included file directly inside onMissingTemplate(), using the private method gives me no output at all.

@perdjurner perdjurner added this to the 2.1.0 milestone Aug 12, 2018
@perdjurner perdjurner added the bug label Aug 12, 2018
@andybellenie andybellenie self-assigned this Sep 24, 2018
@neokoenig neokoenig modified the milestones: 2.1.0, 2.1.1 Feb 24, 2020
@neokoenig neokoenig modified the milestones: 2.1.1, 2.2.0 Apr 12, 2020
@neokoenig neokoenig modified the milestones: 2.2.0, 2.3.0 Apr 20, 2021
@neokoenig
Copy link
Contributor

Think #1067 fixes this

@zainforbjs
Copy link
Contributor

@neokoenig Can this be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants