Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit and refactor create_image_from_file implementation #50

Open
3 tasks
johannesugb opened this issue Aug 29, 2020 · 0 comments
Open
3 tasks

Revisit and refactor create_image_from_file implementation #50

johannesugb opened this issue Aug 29, 2020 · 0 comments
Labels
C++ C++-centric task enhancement New feature or request

Comments

@johannesugb
Copy link
Member

johannesugb commented Aug 29, 2020

The implementations of gvk::create_image_from_file are somewhat strange. Depending on the input format, either gli or stbi is used to load the image.

Review the way these methods are implemented and possibly refactor them. Maybe even come up with an interface that makes more sense (e.g. inferring the format completely automatically instead of passing the desired format to the create_image_from_file(const std::string& aPath, vk::Format aFormat, avk::memory_usage aMemoryUsage = avk::memory_usage::device, avk::image_usage aImageUsage = avk::image_usage::general_texture, avk::sync aSyncHandler = avk::sync::wait_idle()) overload).

It would make sense to work on this issue in conjunction with working on issue #59.

Definition of done:

  • Implementations of gvk::create_image_from_file functions have been evaluated and improved in terms of readability, functionality, and code-reuse.
  • The implementation is less confusing than in the current state --- or at least better documented.
  • gvk::create_image_from_file functions are well documented and the Contribution Guidelines have been followed.
@johannesugb johannesugb added C++ C++-centric task enhancement New feature or request labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ C++-centric task enhancement New feature or request
Development

No branches or pull requests

1 participant