Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved handling of --sort flag and it's interaction with --files #74

Closed
wants to merge 2 commits into from
Closed

Improved handling of --sort flag and it's interaction with --files #74

wants to merge 2 commits into from

Conversation

ConnorGray
Copy link
Contributor 

Invalid values of --sort will now be caught and reported. Added a
dependency on the edit_distance crate to catch typos and offer
suggestions. These are basically usability improvements.

@ConnorGray
Improved handling of --sort flag and it's interaction with --files
7887478 
    Invalid values of --sort will now be caught and reported. Added a
    dependency on the edit_distance crate to catch typos and offer
    suggestions.
@cgag
Copy link
Owner

cgag commented Mar 3, 2018

Sorry I've been travelling and haven't had a chance to test this yet but it looks great. I wasn't really happy with how I did it before and this looks much nicer, and the edit distance stuff is beautiful. Will hopefully get to take a look at this soon. Thanks!

@ConnorGray
Copy link
Contributor Author

No problem! Thanks!

@cgag
Copy link
Owner

cgag commented May 31, 2018

finally got this merged manually, thanks a bunch

@cgag cgag closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ConnorGray @cgag