Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqrt_extension(double) #50

Closed
mglisse opened this issue Apr 10, 2015 · 1 comment
Closed

Sqrt_extension(double) #50

mglisse opened this issue Apr 10, 2015 · 1 comment
Assignees
@sloriot
Labels
Bug Pkg::Kernel_23
Milestone
4.8-beta1

Comments

@mglisse
Copy link
Member

mglisse commented Apr 10, 2015

Sqrt_extension<NT,...> has implicit constructors taking int or NT. When NT is not a builtin type, trying to implicitly construct Sqrt_extension from double picks the int constructor. -Wconversion gives a warning with gcc/clang, Visual Studio seems to warn as well.
@sloriot sloriot mentioned this issue Nov 23, 2015
Merged
@sloriot
Copy link
Member

sloriot commented Nov 23, 2015

Due to some internal usage in the arrangement package the constructor from int cannot be made explicit. I documented the constructor from any NTX in #505. Specifying the template parameter should enable to remove the warning.

@sloriot sloriot closed this as completed Dec 1, 2015
@lrineau lrineau added this to the 4.8-beta milestone Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sloriot sloriot

Labels
Bug Pkg::Kernel_23
Projects
None yet
Milestone
4.8-beta1
Development

No branches or pull requests
3 participants
@sloriot @lrineau @mglisse