Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4.0+ doesn't work on Python 3.6 #41

Closed
nosmoke opened this issue Jun 22, 2020 · 2 comments
Closed

Version 0.4.0+ doesn't work on Python 3.6 #41

nosmoke opened this issue Jun 22, 2020 · 2 comments

Comments

@nosmoke
Copy link

nosmoke commented Jun 22, 2020

You have added "from typing import Protocol" in the latest versions, and Protocol is not available in Python before version 3.8.
This is breaking some of our code that runs on Python 3.6 and until now assumed that as long as you are in version 0.* everything will be fine

@cgarciae
Copy link
Owner

cgarciae commented Jun 22, 2020

Hey @nosmoke ! Thanks for reporting the issue. Fortunately this is a quite fix.

BTW: its a good practice to freeze dependencies (refer to exact versions) for production environments, check out tools like poetry or pipenv which helps you with this.

@cgarciae
Copy link
Owner

Fixed version 0.4.2 via #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants