Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Change Mutable API #19

Merged
merged 9 commits into from May 18, 2022
Merged

Change Mutable API #19

merged 9 commits into from May 18, 2022

Conversation

cgarciae
Copy link
Owner

@cgarciae cgarciae commented Apr 18, 2022

Changes

  • Previously self.mutable(*args, method=method, **kwargs)
  • Is now...... self.mutable(method=method)(*args, **kwargs)
  • Opaque API is removed
  • inplace argument is now only available for apply.
  • Immutable.{mutable, toplevel_mutable} methods are removed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #19 (d5f4eee) into master (a9007a5) will decrease coverage by 0.73%.
The diff coverage is 89.32%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   91.81%   91.08%   -0.74%     
==========================================
  Files           6        6              
  Lines         770      774       +4     
==========================================
- Hits          707      705       -2     
- Misses         63       69       +6     
Impacted Files Coverage Δ
treeo/types.py 81.03% <ø> (-0.64%) ⬇️
treeo/utils.py 87.05% <ø> (-4.04%) ⬇️
treeo/mixins.py 84.61% <78.57%> (-2.45%) ⬇️
treeo/api.py 91.50% <84.21%> (-0.38%) ⬇️
treeo/tree.py 95.47% <96.00%> (+0.06%) ⬆️
treeo/__init__.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@cgarciae cgarciae changed the title No-inplace Change Mutable API Apr 18, 2022
@cgarciae cgarciae added the fix label May 17, 2022
@cgarciae cgarciae merged commit 357f58e into master May 18, 2022
@cgarciae cgarciae deleted the no-inplace branch May 23, 2022 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants