Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Add more Layers #40

Open
4 of 8 tasks
cgarciae opened this issue Nov 15, 2021 · 2 comments
Open
4 of 8 tasks

Add more Layers #40

cgarciae opened this issue Nov 15, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cgarciae
Copy link
Owner

cgarciae commented Nov 15, 2021

The idea is to add more wrappers over Flax layers.

Guidelines

  • Core computation should be done by Flax, unless there is a good reason to re-implement it.
  • Argument names and types should be the same unless there is a good reason to deviate from Flax API.
  • "params" and "batch_stats" are assigned to fields, take implementation of Linear and BatchNorm as references.
  • Must take into account training and frozen state, checkout the implementation of BatchNorm and Dropout as references.
  • Must add test for numerical equivalence, check out test_linear.py as a reference.

Layers List

If you want to work on a layer, feel free to "claim" it via a comment here so others know you are working on it.

@cgarciae cgarciae added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 15, 2021
@ptigwe
Copy link
Contributor

ptigwe commented Nov 15, 2021

On the embedding layer, I think it'll be fine with Embed as opposed to Embedding primarily due to the Flax-like design, plus it seems to be the name used in especially given the first point you make on the guidelines. At the same time, I'm not opposed to Embedding as its used in most frameworks. To the best of my knowledge of the other JAX-based NN libraries, only Trax calls it Embedding, Haiku and Flax both call it Embed.

@cgarciae
Copy link
Owner Author

@ptigwe Agreed. I'd leave it up to the implementer to decide the name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants