Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

MeanSquaredError and MeanAbsoluteError Metrics use old argument names #55

Closed
cgarciae opened this issue Jan 10, 2022 · 0 comments · Fixed by #56
Closed

MeanSquaredError and MeanAbsoluteError Metrics use old argument names #55

cgarciae opened this issue Jan 10, 2022 · 0 comments · Fixed by #56

Comments

@cgarciae
Copy link
Owner

cgarciae commented Jan 10, 2022

Since recently we've been using the following convention for the arguments for Metric's update function:

  • y_pred => preds
  • y_true => target

However, MeanSquareError and MeanAbsoluteError use the old convention:

def update(
self,
y_true: jnp.ndarray,
y_pred: jnp.ndarray,
sample_weight: jnp.ndarray = None,
) -> tp.Any:

def update(
self,
y_true: jnp.ndarray,
y_pred: jnp.ndarray,
sample_weight: jnp.ndarray = None,
) -> tp.Any:

This is not a hard issue for Treex itself but Elegy does rely on this convention and it makes these metrics incompatible (poets-ai/elegy#216).

cc: @anvelezec @jmarrietar

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant