This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
Bumps flax to 0.4.0
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates flax to the most recent version. This currently breaks the current implementation and way in which rng keys of dropout is being handled. Currently have disabled one of the dropout equivalence tests as I am not fully aware if there is a method of directly affecting the value of `next_key` within a treex module.
|
Hey @ptigwe! Thanks a lot for this :)
Yeah, trying to simulate the rng key splits is tricky (I've fought with it in the past). Managed to figure it out though so I pushed the fix + also applied I think this is good to go once CI passes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates flax to the most recent version. This currently breaks the
current implementation and way in which rng keys of dropout is being
handled.
Currently have disabled one of the dropout equivalence tests as I am not
fully aware if there is a method of directly affecting the value of
next_keywithin a treex module.