Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed import of serde::export::Formatter #5

Merged
merged 2 commits into from Jun 4, 2021

Conversation

izderadicka
Copy link
Contributor

  • use std::fmt::Formatter - as it was just reexport from std
  • make bin target conditional on cli feature

Problem is with serde >= 1.0.119 - serde::export in now private module.

izderadicka and others added 2 commits June 1, 2021 10:27
- use std::fmt::Formatter - as it was just reexport from std
- make bin target conditional on cli feature
@cgbur cgbur merged commit d67928c into cgbur:master Jun 4, 2021
@cgbur
Copy link
Owner

cgbur commented Jun 4, 2021

I didn't see this in time before I pushed my fix for the serde formatter. Went ahead and merged to take your suggestion for the [[bin]].

Thanks!

@cgbur cgbur linked an issue Jun 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not compile badge_maker
2 participants