Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dupe functionality introduced with round=true api #23

Closed
adam-zethraeus opened this issue Sep 4, 2014 · 4 comments
Closed

dupe functionality introduced with round=true api #23

adam-zethraeus opened this issue Sep 4, 2014 · 4 comments

Comments

@adam-zethraeus
Copy link
Contributor

#22 (comment)
@adam-zethraeus
Copy link
Contributor Author

Also, if i'm wrong, or i'm just missing context for this decision (perhaps from the ghost side?) please just let me know!

@ErisDS
Copy link

ErisDS commented Sep 5, 2014

@zethraeus there is some more context in the linked issue in express-hbs: TryGhost/express-hbs#66 and in this issue on Ghost: TryGhost/Ghost#2163 (comment), but you're not missing anything critical as I also thought this was duplicate functionality.

I think having the sentence-terminating tags built in might be beneficial though?

@adam-zethraeus
Copy link
Contributor Author

@ErisDS Thanks! I like the idea of having a default heuristic for sentence terminating tags too.

( @remy @cgiffard )

@adam-zethraeus adam-zethraeus mentioned this issue Sep 9, 2014
Merged
@cgiffard
Copy link
Owner

I'm closing this issue as I've merged @zethraeus's changes but it might be worth revisiting to make sure people are happy with the results. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @cgiffard @adam-zethraeus