Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity about is_player_connected() #26

Closed
HanouaJ opened this issue Jun 28, 2020 · 3 comments
Closed

Ambiguity about is_player_connected() #26

HanouaJ opened this issue Jun 28, 2020 · 3 comments

Comments

@HanouaJ
Copy link

HanouaJ commented Jun 28, 2020

It is not clear what is the role of the function is_player_connected(), I assumed it is used to check if the player is already connected or not but It always returns a null.

There must be a way to check if the sign-in to Google Play Games Services was successful and if the player is connected, I tried the _on_player_is_already_connected but it is never called.

@ja-kub
Copy link

ja-kub commented Jul 11, 2020

As it was figured out by @hlfstr here: #5 (comment)
the callback for _on_player_is_already_connected() requires 2 parameters. So the following will work:

func _on_player_is_already_connected(status : bool, id : String) -> void:
	print("hello from _on_player_is_already_connected\nStatus: %s | ID: %s" % [status,id])

@cgisca should update README.md, because currently it's misleading.

@cgisca
Copy link
Owner

cgisca commented Aug 13, 2020

Please check the new version of the plugin. is_player_connected() is now synchronous and you can call it directly without waiting to get the response in the callback. Please take attention that it has a different name -> isSignedIn() .

Check if signed in:
var is_signed_in: bool = play_games_services.isSignedIn()

Closing the issue

@cgisca cgisca closed this as completed Aug 13, 2020
@Losatu
Copy link

Losatu commented Jul 13, 2021

There is no such function "is_player_connected()".

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants