Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

scroll to top if clicking on a accordion on mobile when articleBlockSlider is enabled #7

Closed
gorhgorh opened this issue Jan 5, 2016 · 0 comments · Fixed by #8
Closed

Comments

@gorhgorh
Copy link
Contributor

gorhgorh commented Jan 5, 2016

if i install and enable this extension and have an accordion on my page, on mobile, as expected the articleBlockSlider does not activate, still if i click on an accordion item, the page scroll to the top.

If i change the "_startIndex": 0 to another value, it jumps lower than the top.

_blockSliderScrollToCurrent report the right sizes on mobile and desktop, but it does not seems to be disabled on the other sizes.

i made a simple test repo here
https://github.com/gorhgorh/articleBlockSlider-test

Adapt version : latest (2.0.8)
device : iphone 4 latest ios / android : chrome latest

gorhgorh added a commit to gorhgorh/adapt-articleBlockSlider that referenced this issue Jan 7, 2016
adds checks for screensize to ensure that the plugin is not active on mobile
@gorhgorh gorhgorh mentioned this issue Jan 7, 2016
oliverfoster added a commit that referenced this issue Mar 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant