Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cys bonds not correctly recognized in .gro files and .pdb files without chain identifier #7

Closed
Djurredejong opened this issue Mar 24, 2016 · 1 comment

Comments

@Djurredejong
Copy link
Collaborator

Cys bonds and links given with the options -cys chain/resn/resid,chain/resn/resid or -link chain/resn/resid/atom,chain/resn/resid/atom,bondlength,forceconstant are not correctly recognized for gro files (where no chain can be defined) and pdb files where the chain identifier field is empty.

This can be circomvented by explicitly defining an empty chain identifier on the commandline:
-cys " /CYS/15, /CYS/48".

However, it would be better to internally better handle empty chain identifiers: they should always be None (this is currently done correctly in def str2atom but incorrectly when reading in .gro/.pdb files.

@Djurredejong
Copy link
Collaborator Author

Fixed by commit 4ab1164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant