Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for distributions (Arch in this case) should be done in a more reliable way #92

Closed
WildPenquin opened this issue Jan 6, 2024 · 2 comments
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@WildPenquin
Copy link

WildPenquin commented Jan 6, 2024

Hi!

In setup.py, on line 249:

if 'arch' not in platform.platform():

This does not work on many Arch installations. The kernel version reported by platform.platform() is really independent of the distribution.

On my system:

>>> platform.platform()
'Linux-6.6.9-zen1-1-zen-x86_64-with-glibc2.38'

Also see discussion in AUR.

Cheers!

@WildPenquin
Copy link
Author

WildPenquin commented Jan 6, 2024

I suggest using platform.freedesktop_os_release(). I haven't red the freedesktop standard (just found it), but something like: platform.freedesktop_os_release()['ID'] != 'arch' could work.

See:

EDIT: Of course this test should be only done to test for the distribution(s), and would be an improvement. But that is not enough to determine which libraries are available, as that might change at any time.

@cgohlke
Copy link
Owner

cgohlke commented Jan 7, 2024

The project provides pre-compiled wheels for manylinux_aarch64 on PyPI. AArch64 binaries are also available on conda-forge. If you must build imagecodecs form source and the default configuration does not work, provide a customize_build function in an importable imagecodecs_distributor_setup module. That allows to define which extensions are built and to modify library names, include paths, compiler options, etc.

@cgohlke cgohlke closed this as completed Jan 7, 2024
@cgohlke cgohlke added wontfix This will not be worked on invalid This doesn't seem right labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants