Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf_model_base.py: hidden_activation hardcoded #13

Closed
yjianqing opened this issue May 13, 2018 · 1 comment
Closed

tf_model_base.py: hidden_activation hardcoded #13

yjianqing opened this issue May 13, 2018 · 1 comment

Comments

@yjianqing
Copy link

In line 35 of tf_model_base.py, self.hidden_activation is initialized hardcoded to tf.nn.tanh instead of taking the parameter value.

@cgpotts
Copy link
Owner

cgpotts commented Jun 15, 2018

Thank you for catching this, and my apologies for overlooking it until now – I didn't have my repo notifications set up properly!

@cgpotts cgpotts closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants