Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable update_markdown_toc_test #160

Closed
cgrindel opened this issue Nov 4, 2022 · 1 comment · Fixed by #162
Closed

Enable update_markdown_toc_test #160

cgrindel opened this issue Nov 4, 2022 · 1 comment · Fixed by #162
Labels
bug Something isn't working

Comments

@cgrindel
Copy link
Owner

cgrindel commented Nov 4, 2022

The test failed when applying #159. Output:

FAIL: //tests/markdown_tests/tools_tests:update_markdown_toc_test (see /private/var/tmp/_bazel_chuck/de41cc038adf29b29c7e407666a8b614/execroot/cgrindel_bazel_starlib/bazel-out/darwin-fastbuild/testlogs/tests/markdown_tests/tools_tests/update_markdown_toc_test/test.log)
INFO: From Testing //tests/markdown_tests/tools_tests:update_markdown_toc_test:
==================== Test output for //tests/markdown_tests/tools_tests:update_markdown_toc_test:
With defaults Expected to be equal. expected: # Document Title

## Table of Contents

<!-- MARKDOWN TOC: BEGIN -->
* [Chicken](#chicken)
  * [Smidgen](#smidgen)
<!-- MARKDOWN TOC: END -->

## Chicken

### Smidgen, actual: # Document Title

## Table of Contents

<!-- MARKDOWN TOC: BEGIN -->
<!-- MARKDOWN TOC: END -->

## Chicken

### Smidgen
================================================================================
@cgrindel cgrindel added the bug Something isn't working label Nov 4, 2022
@cgrindel
Copy link
Owner Author

cgrindel commented Nov 7, 2022

The issue appears to be related to how the HTML is generated in the github-markdown-toc.go utility. The tool uses a regexp to extract the header information from HTML generated by GitHub. The order of the anchor attributes changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant