upgrade cg-busy 4.1.4 to npm

[ghernandez81]

No description provided.

[ghernandez81]

currently in npm it's 4.1.0

[gabehayes]

Also, there is a tag missing for v4.1.4, so you can't event set a branch/tag target in the interim.

[cgross]

Thats because there is no 4.1.4. The latest ver is 4.1.3.

[Valko54]

Please, can you upgrade angular-busy in NPM ? (npm install angular-busy@4.1.3 doesn't exist)

[axelson]

+1

[benoror]

+1 Hi, I would also benefit from having it updated, let me give you my reason:

Support for Webpack + CommonJS Package Manager

Motivation

I'm in the process of refactoring an app to support modern JS tooling like NPM, Webpack & ES6.

Code Change

A small change is needed to support CommonJS:

/* commonjs package manager support (eg componentjs) */
if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports){
  module.exports = 'cgBusy';
}

• Source: ui-router release
• Or: UMD (Universal Module Definition)

Working Examples

I have done other PRs for some of my dependencies:

• Support for Webpack + CommonJS Package Manager wix-incubator/angular-tree-control#152
• Support Webpack + CommonJS Package Manager PatrickJS/angular-md5#8
  • commonjs package manager support (fix #8) PatrickJS/angular-md5#9
• commonjs package manager support muratcorlu/angular-urlify#1
• commonjs + bower package manager support tarkanlar/Angular-Urlify#1

Sources

• Using Angular 1.x With ES6 and Webpack by Jesus Rodriguez
• Webpack & Angular by Shawn McKay
• Angular and Webpack for Modular Applications by @kentcdodds
• NPM for Everything

[benoror]

BTW @gabehayes you can use latest master commit with the following format in package.json:

"angular-busy": "git+https://github.com/cgross/angular-busy.git"

[myflowpl]

+1
but i think there should be module.exports = 'cgBusy' instead of module.exports = 'angular-md5'
then it's compatibile with CommonJS and Angular style (and Webpack)

[benoror]

You're right, fixed! Any chance we could se an npm release soon @cgross ?

[bikegriffith]

Would love to see this so I don't have to fork and maintain to use in my webpack-driven project