Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nullable types #4

Closed
wants to merge 2 commits into from
Closed

Conversation

tadfisher
Copy link

@tadfisher tadfisher commented Sep 21, 2022

Fixes #3

Relax the type constraint on encodeToBundle and decodeFromBundle functions that use KSerializer<T> or look up serializers via serializersModule.

Align the type constraint on rememberSaveable and Saver to match upstream compose; there is still an : Any constraint for rememberSaveable<T : Any> : T but there is none on rememberSaveable<T> : MutableState<T>.

Also, quickly configure the desktop version of sample-compose for easy testing.

@chRyNaN
Copy link
Owner

chRyNaN commented Sep 22, 2022

@tadfisher I apologize, I missed this PR. After I saw issue #3, I started hacking away at the solution trying to be diligent, and released the fix already. The solution seems the same. If you'd like, you could make a separate PR adding the sample-compose desktop logic to the build file you added in these changes. Sorry again.

@chRyNaN chRyNaN closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoding nullable types from Bundle
2 participants