Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Hyper 1.2.1 #5

Closed
lanthaler opened this issue Mar 8, 2017 · 7 comments
Closed

Doesn't work with Hyper 1.2.1 #5

lanthaler opened this issue Mar 8, 2017 · 7 comments

Comments

@lanthaler
Copy link

I just tried the plugin with Hyper 1.2.1. It breaks split panes. Here's my config:

paneNavigation: {
  debug: true,
  hotkeys: {
    navigation: {
      up: 'shift+up',
      down: 'shift+down',
      left: 'shift+left',
      right: 'shift+right'
    },
    permutation_modifier: 'ctrl', // Added to jump and navigation hotkeys for pane permutation
  },
  showIndicators: false,
  focusOnMouseHover: false
}

and here's the debug output:

(re)loading renderer plugins
index.html:34 total init time 284.67499999999995
index.js:31 |HYPER-PANE| updateChildrenFrames: call on af684550-816f-448d-ae38-60d7203c6733
index.js:31 |HYPER-PANE| updateChildrenFrames: no children found, skipping 365ef91c-1377-4709-84dc-73e9681ce29d
index.js:524 Uncaught TypeError: Cannot read property 'getTermDocument' of undefined
index.js:31 |HYPER-PANE| updateChildrenFrames: call on af684550-816f-448d-ae38-60d7203c6733
index.js:31 |HYPER-PANE| dealing child 324163d4-c576-416f-96a0-e577632a8e93
index.js:31 |HYPER-PANE| Setting frame for Object 0 0.5
index.js:31 |HYPER-PANE| updateChildrenFrames: call on 324163d4-c576-416f-96a0-e577632a8e93
index.js:31 |HYPER-PANE| updateChildrenFrames: sessionUid found, skipping 365ef91c-1377-4709-84dc-73e9681ce29d
index.js:31 |HYPER-PANE| dealing child 83f72570-eb48-483c-8f82-f77b3c255ce9
index.js:31 |HYPER-PANE| Setting frame for Object 0.5 0.5
index.js:31 |HYPER-PANE| updateChildrenFrames: call on 83f72570-eb48-483c-8f82-f77b3c255ce9
index.js:31 |HYPER-PANE| updateChildrenFrames: sessionUid found, skipping f04d4a8b-10b7-4585-bd22-30f8e5543a57
index.js:524 Uncaught TypeError: Cannot read property 'getTermDocument' of undefined
7bundle.js:39 Uncaught TypeError: Cannot read property 'getPrefs' of undefined
bundle.js:11 Uncaught TypeError: Cannot read property 'focusHyperCaret' of undefined
3bundle.js:39 Uncaught TypeError: Cannot read property 'getPrefs' of undefined
@iamstarkov
Copy link

did you restart the hyper?

@ltegman
Copy link

ltegman commented Mar 10, 2017

I've noticed this as well, but for me it only occurs if I have showIndicators set to false. If I leave it true everything works as expected.

@chabou
Copy link
Owner

chabou commented Mar 10, 2017

Thank you for your feedbacks. I'll check that soon

@iamstarkov
Copy link

@lanthaler can you update to the latest version?

@chabou
Copy link
Owner

chabou commented Mar 11, 2017

fixed by d89f68d
@ltegman thanks to have pointed me in the right direction

@chabou
Copy link
Owner

chabou commented Mar 11, 2017

fix published with version v1.1.2

@lanthaler
Copy link
Author

Opened #7 because this still doesn't seem to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants