Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the field: other commonly-used packages #10

Closed
lnferris opened this issue Dec 19, 2023 · 1 comment
Closed

State of the field: other commonly-used packages #10

lnferris opened this issue Dec 19, 2023 · 1 comment

Comments

@lnferris
Copy link

lnferris commented Dec 19, 2023

This is part of JOSS review.

TMD 2.5 cites two alternative versions of the toolbox, Fortran (https://www.tpxo.net/otps) and Python (https://github.com/tsutterley/pyTMD). It is appropriate to mention these around line 27 of the paper, as you have done in README.md.

Similarly, it is probably appropriate to explain or change "The MATLAB version...no major updates...since its inception". The citation for TMD 2.5 is from 2022 which is inconsistent with the narrative that no one has touched it since its inception.

@chadagreene
Copy link
Owner

We've added mention of the Fortran and Python versions to the paper.

We don't exactly state that TMD hasn't been touched since its inception. We say that TMD3.0 is based on the same equations that were originally implemented in Fortran in the 1990s, and that there haven't been any major updates since it was converted to MATLAB decades ago. The 2022 date associated with TMD2.5 is just the date the code was added to a repository--it had been available to the public for many years before from GitHub, and before that, from the ESR website directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants