Feature/stackImagePositionSynchronizer does not crash if no position found #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 5, 2017 14:50
added 6 commits
September 27, 2017 11:58
fusionRenderer does not crash if the layer is destroyed while rendering (#245)
Merge chafey/master
LengthTool now uses PixelSpacing provided by MetaDataProvider, thanks…
Merge chafey/Master
Merge chafey/master
…r_does_not_crash_if_no_position_found # Conflicts: # src/synchronization/stackImagePositionSynchronizer.js
swederik
reviewed
Nov 23, 2017
|
|
||
| const stackToolDataSource = getToolState(targetElement, 'stack'); | ||
| const stackData = stackToolDataSource.data[0]; | ||
|
|
||
| let minDistance = Number.MAX_VALUE; | ||
| let newImageIdIndex = -1; | ||
| let nbComparedPositions = 0; |
There was a problem hiding this comment.
I guess this is a remnant of testing? If you remove nbComparedPositions I think we can merge this PR
swederik
reviewed
Nov 23, 2017
| sourceImagePosition = convertToVector3(sourceImagePlane.imagePositionPatient); | ||
| } | ||
|
|
||
| if (sourceImagePosition === undefined) { |
There was a problem hiding this comment.
I just realized there is no way this condition can happen. convertToVector3 doesn't have any way to return undefined. I guess it's better to move this If statement above the other one and check if sourceImagePlane.imagePositionPatient is undefined.
|
That looks better! Thanks! |
adreyfus
deleted the
feature/stackImagePositionSynchronizer_does_not_crash_if_no_position_found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.