Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Chipping away at modernizing the Readme.md #283

Merged

Conversation

dannyrb
Copy link
Member

@dannyrb dannyrb commented Nov 11, 2017

@swederik working on that penance for my earlier accidental merge 🙏

Let me know if anything in here seems off, or if you'd like to see anything added.

…ttempting to identify common questions/information users may want when first hitting the repo
@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling 4768758 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling 074c012 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling 8f06dde on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling b5f1595 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling b8d4c5d on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling f469f4f on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling d5d45a4 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling e0a85b1 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling aca0daa on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@dannyrb
Copy link
Member Author

dannyrb commented Nov 11, 2017

@swederik you can see the latest version at this URL:

https://github.com/dannyrb/cornerstoneTools/blob/aca0daa782453ce5c4b02b1fa942a160ece2e1f4/README.md

I'm curios to hear your thoughts on:

  • Section ordering
  • Moving backlog to "tracked issues" (and then removing the backlog section)
  • Any other comments, concerns, or suggestions?

Hope I'm on the right track.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling 12e963e on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 3.833% when pulling b4e9056 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@dannyrb
Copy link
Member Author

dannyrb commented Nov 13, 2017

Really sorry about all of these "coveralls" notifications. The only good way to preview a layout is to make a commit and observe the changes.

Latest can be found here: https://github.com/dannyrb/cornerstoneTools/blob/b4e90565f22841b40e7fe30320ea3a9a3bc59eef/README.md

Bumped to 4 per row to allow for easier viewing on mobile.

@swederik
Copy link
Member

This looks awesome to me! I also love how the git branch is marked as a chore :-)

Did you try Atom to preview the github-flavoured markdown? I also want to make coveralls less verbose.

@dannyrb
Copy link
Member Author

dannyrb commented Nov 13, 2017

Haha, my org uses chore, feature, and bug to prefix branches. They tend to align well with describing a single "story".

Good call out on using Atom! I actually use VS Code, but your comment reminded me to do some digging for a plugin: https://marketplace.visualstudio.com/items?itemName=bierner.markdown-preview-github-styles

👍 Thanks (:

I intend to:

  • Add remaining GIFs
  • Spellcheck
  • Misc. tidying

And then I'll @mention you to see if we're good for a PR.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 3.795% when pulling b882292 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@dannyrb
Copy link
Member Author

dannyrb commented Nov 26, 2017

@swederik this should be ready for review.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 3.795% when pulling bff24f1 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@swederik
Copy link
Member

Looks good to me! Shall we merge it?

README.md Outdated
View the [live examples](https://rawgithub.com/chafey/cornerstoneTools/master/examples/index.html) to see this
library in action!
* View [live examples](https://rawgithub.com/chafey/cornerstoneTools/master/examples/index.html) of individual tools
* Take a peak at a [simple image viewer](http://chafey.github.io/cornerstoneDemo/) built on cornerstone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean peek, not peak?

@dannyrb
Copy link
Member Author

dannyrb commented Nov 29, 2017 via email

@dannyrb
Copy link
Member Author

dannyrb commented Nov 29, 2017

Going to :shipit:
I'll likely make another quick PR to update image sources to use relative paths. Should make the change to an org easier.

Please feel free to queue up any documentation items you'd like to see. I'm starting to work on a hit list that prioritizes informing contributors/extenders.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 3.795% when pulling aff5f52 on dannyrb:chore/make-readme-more-contributor-friendly into 8f8ddd2 on chafey:master.

@dannyrb dannyrb merged commit 449a084 into cornerstonejs:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants