Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXR support #1628

Open
HeCorr opened this issue Mar 5, 2023 · 5 comments
Open

EXR support #1628

HeCorr opened this issue Mar 5, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@HeCorr
Copy link

HeCorr commented Mar 5, 2023

Motivation
The software doesn't currently support the EXR/OpenEXR image format which is widely used in the VFX and 3D industry.

image

Description
I would like to see EXR support being added.

Alternatives
The current workaround to using EXR images is to first convert them into PNG images and use those instead, but that's by no means recommended as color values will be clamped.
The same goes to saving images, you need to first save output images as PNGs and then convert them to EXRs, but again, that is not a good idea as PNG cannot carry the amount of information EXR can.

@RunDevelopment RunDevelopment added the enhancement New feature or request label Mar 6, 2023
@RunDevelopment
Copy link
Member

It shouldn't be hard to add support for EXR images.

Do you happen to have an example file I could use for tests? I can't find any online...

@HeCorr
Copy link
Author

HeCorr commented Mar 6, 2023

Sure thing!

Suzanne.zip

I've included a PNG for reference if needed.

The EXR was saved with these settings:

image

@RunDevelopment
Copy link
Member

This won't be easy after all.

OpenCV does support EXR, but in a really unfortunate way. They are using a somewhat old version of the OpenEXR library under the hood, which has several security vulnerabilities, including ones that enable arbitrary code execution. As such, we cannot enable for support for EXR in OpenCV without compromising security.

opencv/opencv#21326
https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=openexr

@HeCorr
Copy link
Author

HeCorr commented Mar 7, 2023

that's understandable. I believe other software (such as Natron) uses OpenImageIO, but I'm guessing it wouldn't be feasible to implement it into chaiNNer.

@mrjschulte
Copy link
Contributor

Just a small update: with the new "Log to Linear" node you can now bring in a Cineon/logarithmicly encoded 16bit TIFF and use the node to convert that back to Scene linear float.

Please do not forget that currently chaiNNer nodes clamp the float output to 0-1 so there's quite a bit of work to be done to get chaiNNer to support true unbounded floating point workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants