Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the definition of lk_type in plksr #256

Closed
umzi2 opened this issue May 13, 2024 · 3 comments · Fixed by #264
Closed

About the definition of lk_type in plksr #256

umzi2 opened this issue May 13, 2024 · 3 comments · Fixed by #264
Labels
enhancement New feature or request

Comments

@umzi2
Copy link

umzi2 commented May 13, 2024

Hello, I noticed that you decided not to add a definition for lk_type in plksr. In general, I don’t think that anyone will change this parameter, but if they change it, the model will become incompatible. Can its definition and the following parameters be added? I did it like this:

@RunDevelopment RunDevelopment added the enhancement New feature or request label May 13, 2024
@joeyballentine
Copy link
Member

Thanks for letting us know about this

@joeyballentine
Copy link
Member

Just FYI: your repo is still GPLv3, so me looking at it, legally speaking, means I can now not implement this in spandrel without violating your license since spandrel is now MIT licensed. RunDevelopment now has to implement this instead of me.

@joeyballentine
Copy link
Member

Btw, don't take that last comment the wrong way. I appreciate you pointing this out for us -- I just wanted to mention it in case you were unaware that we now cannot reference nusselt anymore, becusse I also was not aware of that until I started implenting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants