You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In work I am doing to solve #33, I noticed that this test will fail:
it('returns true if Comparator says so even on primitives (switch arg order)',function(){varvalueA={a: 1};varvalueB={a: newMatcher(function(value){returntypeofvalue==='number';}),};assert(eql(valueA,valueB,{comparator: matcherComparator})===true,'eql({a:1}, {a:value => typeof value === "number"}, <comparator>) === true');});
This only changes the argument order from the existing test. This is because only the left-hand side is checked as a primitive, when really both sides should be to ensure identical behavior.
I will fix this as part of a PR, but I believe we'll end up breaking null comparator behavior.
The text was updated successfully, but these errors were encountered:
In work I am doing to solve #33, I noticed that this test will fail:
This only changes the argument order from the existing test. This is because only the left-hand side is checked as a primitive, when really both sides should be to ensure identical behavior.
I will fix this as part of a PR, but I believe we'll end up breaking
null
comparator behavior.The text was updated successfully, but these errors were encountered: