Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Database to Store Supported Assets #53

Closed
zahin-mohammad opened this issue Apr 8, 2021 · 1 comment
Closed

Use Database to Store Supported Assets #53

zahin-mohammad opened this issue Apr 8, 2021 · 1 comment
Labels
low priority Non-goal tasks refactor Change all the things

Comments

@zahin-mohammad
Copy link
Member

Currently, we hardcode supported assets in supported.go

// TODO: Move these to a table in PSQL
func GetSupportedAssets() map[string]bool {
	return map[string]bool{
		"BTC":  true,
		"ETH":  true,
		"USDT": true,
		"USD":  true,
	}
}

By moving this to the database, we can easily create a script to update/remove supported coins (ex. top 100 coins).

@zahin-mohammad zahin-mohammad added low priority Non-goal tasks refactor Change all the things labels Apr 8, 2021
@zahin-mohammad
Copy link
Member Author

On the other hand, it makes it easier on local dev to have this just be go object. For the case of supporting other coins easily, we can make a script to create a go object just for prod/test/dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Non-goal tasks refactor Change all the things
Projects
None yet
Development

No branches or pull requests

1 participant