Skip to content

Commit

Permalink
sdk/node/test: ensure callback support for all query methods
Browse files Browse the repository at this point in the history
Closes #1304
  • Loading branch information
jeffomatic authored and iampogo committed Jun 12, 2017
1 parent 09f105a commit 6125ae2
Show file tree
Hide file tree
Showing 13 changed files with 118 additions and 40 deletions.
2 changes: 1 addition & 1 deletion generated/rev/RevId.java
@@ -1,4 +1,4 @@

public final class RevId {
public final String Id = "main/rev3229";
public final String Id = "main/rev3230";
}
2 changes: 1 addition & 1 deletion generated/rev/revid.go
@@ -1,3 +1,3 @@
package rev

const ID string = "main/rev3229"
const ID string = "main/rev3230"
2 changes: 1 addition & 1 deletion generated/rev/revid.js
@@ -1,2 +1,2 @@

export const rev_id = "main/rev3229"
export const rev_id = "main/rev3230"
2 changes: 1 addition & 1 deletion generated/rev/revid.rb
@@ -1,4 +1,4 @@

module Chain::Rev
ID = "main/rev3229".freeze
ID = "main/rev3230".freeze
end
15 changes: 12 additions & 3 deletions sdk/node/test/accessTokens.js
Expand Up @@ -168,25 +168,34 @@ describe('Access token', () => {
// tested in the promises test.
describe('Callback support', () => {

it('Access token creation', (done) => {
it('create', (done) => {
client.accessTokens.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Access token deletion', (done) => {
it('delete', (done) => {
client.accessTokens.delete(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Access token query', (done) => {
it('query', done => {
client.accessTokens.query(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('queryAll', done => {
client.accessTokens.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

})
})
21 changes: 17 additions & 4 deletions sdk/node/test/accounts.js
Expand Up @@ -147,32 +147,45 @@ describe('Account', () => {
// tested in the promises test.
describe('Callback support', () => {

it('Single account creation', (done) => {
it('create', (done) => {
client.accounts.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Batch account creation', (done) => {
it('createBatch', (done) => {
client.accounts.createBatch(
[{}, {}], // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Single account tags update', (done) => {
it('updateTags', (done) => {
client.accounts.updateTags(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Batch account tags update', (done) => {
it('updateTagsBatch', (done) => {
client.accounts.updateTagsBatch(
[{}, {}], // intentionally blank
() => done() // intentionally ignore errors
)
})

it('query', done => {
client.accounts.query({}, done)
})

it('queryAll', done => {
client.accounts.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

})
})
21 changes: 17 additions & 4 deletions sdk/node/test/assets.js
Expand Up @@ -147,32 +147,45 @@ describe('Asset', () => {
// tested in the promises test.
describe('Callback support', () => {

it('Single asset creation', (done) => {
it('create', (done) => {
client.assets.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Batch asset creation', (done) => {
it('createBatch', (done) => {
client.assets.createBatch(
[{}, {}], // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Single asset tags update', (done) => {
it('updateTags', (done) => {
client.assets.updateTags(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Batch asset tags update', (done) => {
it('updateTagsBatch', (done) => {
client.assets.updateTagsBatch(
[{}, {}], // intentionally blank
() => done() // intentionally ignore errors
)
})

it('query', done => {
client.assets.query({}, done)
})

it('queryAll', done => {
client.assets.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

})
})
10 changes: 4 additions & 6 deletions sdk/node/test/authorizationGrants.js
Expand Up @@ -88,24 +88,22 @@ describe('Authorization grant', () => {
// tested in the promises test.
describe('Callback support', () => {

it('Authorization grant creation', (done) => {
it('create', (done) => {
client.authorizationGrants.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Authorization grant deletion', (done) => {
it('delete', (done) => {
client.authorizationGrants.delete(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Authorization grant list', (done) => {
client.authorizationGrants.list(
() => done() // intentionally ignore errors
)
it('list', (done) => {
client.authorizationGrants.list(done)
})
})
})
16 changes: 16 additions & 0 deletions sdk/node/test/balances.js
Expand Up @@ -73,4 +73,20 @@ describe('Balance', () => {
})
})

describe('Callback support', () => {

it('query', done => {
client.balances.query({}, done)
})

it('queryAll', done => {
client.balances.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

})

})
15 changes: 10 additions & 5 deletions sdk/node/test/mockHsmKeys.js
Expand Up @@ -60,17 +60,22 @@ describe('MockHSM key', () => {
// tested in the promises test.
describe('Callback style', () => {

it('Key creation', (done) => {
it('create', (done) => {
client.mockHsm.keys.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Key querying', (done) => {
client.mockHsm.keys.query(
{}, // intentionally blank
() => done() // intentionally ignore errors
it('query', done => {
client.mockHsm.keys.query({}, done)
})

it('queryAll', done => {
client.mockHsm.keys.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

Expand Down
15 changes: 10 additions & 5 deletions sdk/node/test/transactionFeeds.js
Expand Up @@ -136,17 +136,22 @@ describe('Transaction feed', () => {
// These just test that the callback is engaged correctly. Behavior is
// tested in the promises test.
describe('Callback support', () => {
it('Creation', done => {
it('create', done => {
client.transactionFeeds.create(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Querying', done => {
client.transactionFeeds.query(
{}, // intentionally blank
() => done() // intentionally ignore errors
it('query', done => {
client.transactionFeeds.query({}, done)
})

it('queryAll', done => {
client.transactionFeeds.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})
})
Expand Down
23 changes: 14 additions & 9 deletions sdk/node/test/transactions.js
Expand Up @@ -223,26 +223,31 @@ describe('Transaction', () => {
// tested in the promises test.
describe('Callback support', () => {

it('Transaction query', (done) => {
client.transactions.query(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Transaction build', (done) => {
it('build', (done) => {
client.transactions.build(
() => {}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('Transaction submit', (done) => {
it('submit', (done) => {
client.transactions.submit(
{}, // intentionally blank
() => done() // intentionally ignore errors
)
})

it('query', done => {
client.transactions.query({}, done)
})

it('queryAll', done => {
client.transactions.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})

})
})
14 changes: 14 additions & 0 deletions sdk/node/test/unspentOutputs.js
Expand Up @@ -71,4 +71,18 @@ describe('Unspent output', () => {
})
})

describe('Callback support', () => {
it('query', done => {
client.unspentOutputs.query({}, done)
})

it('queryAll', done => {
client.unspentOutputs.queryAll(
{},
(t, next, queryDone) => queryDone(),
done
)
})
})

})

0 comments on commit 6125ae2

Please sign in to comment.