dashboard: add test for filtering assets and accounts #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarvin
reviewed
Jul 18, 2017
dashboard/test/specs/accounts.js
Outdated
| .then(() => testHelpers.createAccount(id1, {tags: {x: tag1}})) | ||
| .then(() => testHelpers.createAccount(id2, {tags: {x: tag2}})) | ||
| .then(() => testHelpers.createAccount(id3, {tags: {x: tag1}})) | ||
| .then((account) => browser.url('/accounts')) |
There was a problem hiding this comment.
do we need the account param here?
There was a problem hiding this comment.
nope nice catch!
jeffomatic
changed the title
dominic
approved these changes
Jul 18, 2017
iampogo
force-pushed
the
dash-filtering-tests
branch
from
fd6c92d
to
7bf7e0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes list-item tests to make them less brittle.