Validate sender input to complete e2e payjoin test with receiver contribution #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
commented
Jan 27, 2023
DanGould
force-pushed
the
e2e-receiver-adds-input
branch
from
5882671
to
a4437a3
Compare
DanGould
changed the title
benthecarman
reviewed
Feb 3, 2023
payjoin/src/sender/mod.rs
Outdated
| ); | ||
| if let Some(script_sig) = &proposed.psbtin.final_script_sig { | ||
| total_weight += Weight::from_non_witness_data_size( | ||
| 32 + 4 + 4 + script_sig.encoded_size(), |
There was a problem hiding this comment.
if there's no script_sig you don't add the 32 + 4 + 4 to the total weight, I assume that is the outpoint and sequence values
There was a problem hiding this comment.
Thanks for the review Ben 🎈
Your assumption is correct, and is now documented.
Isn't this the branch where there is indeed a script_sig? The no script_sig should be handled by if let Some(script_witness) below. Do you mean if the transaction has no segwit inputs?
Do you have a clue what unit tests for this code might be useful? I guess I should find some transactions with known weights and check this code against them. There are some examples in that referenced issue but I don't know where they came from.
DanGould
force-pushed
the
e2e-receiver-adds-input
branch
2 times, most recently
from
39df3b6
to
5911ef1
Compare
Verify receiver PSBT inputs are finalized and contribute weight. final_script_sig, final_script_witness may be independent or present together as in the case of a P2WSH spend. This only adds input-specific weight. The check_fees method calculates cumulative weight changes.
DanGould
force-pushed
the
e2e-receiver-adds-input
branch
from
5911ef1
to
575b7d4
Compare
DanGould
force-pushed
the
e2e-receiver-adds-input
branch
from
575b7d4
to
6073866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally! Not just input substitution! Full on payjoin!
The sender change includes Sender input verification
AND weight calculation for the amount of weight those inputs add. Please review for both design and correctness.