Trainer2 #1285
Merged
Trainer2 #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| also useful when the order of examples is important and should not be | ||
| broken. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
Consider adding a "shuffle" (bool) argument, with default value False. If set to True, it takes on the same behavior as ShuffledIterator. There seems to be quite a bit of code duplication between these two classes. If this change is implemented, ShuffledIterator could then be removed.
There was a problem hiding this comment.
Thank you, I agree with you. I updated the code and merge these iterators into SerialIterator.
Fix document to pass test
|
@beam2d I checked ExponentialShift. It seems OK. |
|
|
||
| Chainer provides some iterators that implement typical strategies to create minibatches by iterating over datasets. | ||
| :class:`SerialIterator` is the simplest one, which extract mini batches in the main thread. | ||
| :class:`MultiprocessIterator` is a parallelized version of :class:`ShuffledIterator`. It maintains worker subprocesses to load the next mini batch in parallel. |
There was a problem hiding this comment.
ShuffledIterator does no longer exist.
Use datasets insteald of using ptb data directly
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #914. I wrote an updated version of the training loop abstraction. This includes many improvements based on the feedback to the old version (#958). For example,
I have not updated the tutorial document yet, which should be done before merging it.