Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent leaking from multiprocessiterator. #4946

Closed
jnishi opened this issue Jun 18, 2018 · 0 comments · Fixed by #4972
Closed

Prevent leaking from multiprocessiterator. #4946

jnishi opened this issue Jun 18, 2018 · 0 comments · Fixed by #4972
Labels
pr-ongoing Pull-request is being worked on to address the labeled ticket.

Comments

@jnishi
Copy link
Contributor

jnishi commented Jun 18, 2018

The amount of memory is growing when we use MultiprocessIterator in large dataset training. This can be prevented by settingmaxtasksperchild in using multiprocess.Pool
https://github.com/chainer/chainer/blob/master/chainer/iterators/multiprocess_iterator.py#L345

Could you add maxtasksperchild?
Though it may cause performance issue if new process is created for every iterator, one process per 10 or 20 iteration will not cause performance issue (if it does, it is so fast that it is not needed to prefetch) and it is enough to reduce memory.

@kmaehashi kmaehashi added the prio:high High priority. Urgent and needs to be worked on as soon as possible. label Aug 27, 2018
@kmaehashi kmaehashi added pr-ongoing Pull-request is being worked on to address the labeled ticket. and removed prio:high High priority. Urgent and needs to be worked on as soon as possible. labels Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-ongoing Pull-request is being worked on to address the labeled ticket.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants