Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurrent and batched TRPO #446

Merged
merged 19 commits into from Aug 27, 2019
Merged

Recurrent and batched TRPO #446

merged 19 commits into from Aug 27, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Apr 28, 2019 •
edited

Merge #431 before this PR.

@muupan muupan mentioned this pull request May 1, 2019
Merged
@muupan muupan mentioned this pull request May 6, 2019
Open
@muupan muupan changed the title [WIP] Recurrent and batched TRPO Recurrent and batched TRPO Jun 25, 2019
@muupan muupan assigned toslunar and unassigned toslunar Jun 25, 2019
@muupan muupan requested a review from toslunar June 25, 2019 04:45
@toslunar toslunar self-assigned this Jun 27, 2019
toslunar
toslunar reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recurrent part LGTM except for minor comments.

chainerrl/agents/trpo.py Outdated Show resolved Hide resolved
chainerrl/agents/trpo.py Outdated Show resolved Hide resolved
@muupan muupan requested a review from toslunar August 15, 2019 14:22
toslunar
toslunar approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar
Copy link
Member

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit bcac906:

@toslunar toslunar added this to the v0.8 milestone Aug 26, 2019
@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

Let me investigate the failure in pfn-public-ci/chainerrl.py3.gpu .

@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit c23c171:

@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

I added changes to address flexCI failurue:

Remaining flexCI failures are only flakey tests and #533

@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 805f888:

@toslunar
Copy link
Member

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 805f888:

@muupan muupan requested a review from toslunar August 26, 2019 12:37
@muupan
Copy link
Member Author

muupan commented Aug 26, 2019 •
edited

@toslunar Can you review the changes I added?

@muupan
Copy link
Member Author

muupan commented Aug 27, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit d8fa213:

toslunar
toslunar approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit 038519e into chainer:master Aug 27, 2019
@muupan muupan deleted the recurrent-trpo branch August 27, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
enhancement
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muupan @toslunar @pfn-ci-bot