New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python2 support #473
Drop python2 support #473
Conversation
/test |
Successfully created a job for commit 98d3520: |
/test |
Successfully created a job for commit ee9036a: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove six
?
% git grep 'import six'
chainerrl/misc/makedirs.py:import six
chainerrl/replay_buffers/episodic.py:import six.moves.cPickle as pickle
chainerrl/replay_buffers/replay_buffer.py:import six.moves.cPickle as pickle
tests/misc_tests/test_random.py:import six
LGTM except for it.
/test |
Successfully created a job for commit 135ff1d: |
Good point! I removed six. By this change |
/test |
Successfully created a job for commit 441f939: |
/test |
Successfully created a job for commit 7acb18e: |
Resolves #463Resolves #392
Resolves #467
future
is removed from dependencies__future__
is removedppa:jonathanf
toppa:cran
for installing ffmpeg since the former is no longer available