Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python2 support #473

Merged
merged 26 commits into from Dec 16, 2019
Merged

Drop python2 support #473

merged 26 commits into from Dec 16, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Jun 9, 2019

Resolves #463
Resolves #392
Resolves #467

  • Travis CI with python 2 is stopped
  • future is removed from dependencies
  • import from __future__ is removed
  • hacks for python 2 are removed (Support Python2/3 JSON dumps of dicts. #392)
  • switched from ppa:jonathanf to ppa:cran for installing ffmpeg since the former is no longer available
  • remove use of six
  • remove fastcache, funcsigs, statistics as dependencies

@prabhatnagarajan prabhatnagarajan requested review from prabhatnagarajan and removed request for prabhatnagarajan July 16, 2019 08:01
@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 98d3520:

@muupan
Copy link
Member Author

muupan commented Dec 11, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit ee9036a:

@muupan muupan changed the title [WIP] Drop python2 support Drop python2 support Dec 11, 2019
@toslunar toslunar self-assigned this Dec 12, 2019
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove six?

% git grep 'import six'
chainerrl/misc/makedirs.py:import six
chainerrl/replay_buffers/episodic.py:import six.moves.cPickle as pickle
chainerrl/replay_buffers/replay_buffer.py:import six.moves.cPickle as pickle
tests/misc_tests/test_random.py:import six

LGTM except for it.

@muupan
Copy link
Member Author

muupan commented Dec 12, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 135ff1d:

@muupan
Copy link
Member Author

muupan commented Dec 12, 2019

Good point! I removed six. By this changechainerrl.misc.makedirs is now completely the same as os.makedirs, so I removed the file.

chainerrl/optimizers/nonbias_weight_decay.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@muupan
Copy link
Member Author

muupan commented Dec 12, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 441f939:

@muupan
Copy link
Member Author

muupan commented Dec 12, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 7acb18e:

@muupan muupan requested a review from toslunar December 12, 2019 10:13
@toslunar toslunar merged commit 5d833d6 into chainer:master Dec 16, 2019
@muupan muupan deleted the drop-python2 branch December 17, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python2 support CI failure with Python 2 and chainer==6.0.0 Support Python2/3 JSON dumps of dicts.
4 participants