Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell.Builder.open(Shell.OnCommandResultListener) doesn't work if user rejects SU request #55

Closed
Mygod opened this issue Jul 12, 2016 · 6 comments
Closed

Shell.Builder.open(Shell.OnCommandResultListener) doesn't work if user rejects SU request #55

Mygod opened this issue Jul 12, 2016 · 6 comments

Comments

@Mygod
Copy link
Contributor

Mygod commented Jul 12, 2016

This should be if (fCommand.onCommandResultListener != null).

@dschuermann
@dschuermann
Copy link
Contributor

Make a pull request? :)

@Mygod
Copy link
Contributor Author

Mygod commented Jul 12, 2016

This bug exists for almost 2 years. Is it that no one uses Shell.Interactive now?

@dschuermann
Copy link
Contributor

I think nobody uses Shell without su access.

@Mygod
Copy link
Contributor Author

Mygod commented Jul 12, 2016

Umm good point. But why request SU twice when you can request once?

@Chainfire
Copy link
Owner

The same change should be applied a few lines below ...

Mygod added a commit to Mygod/libsuperuser that referenced this issue Jul 12, 2016
@Mygod
Fix Chainfire#55 in the handler runnable
b6ad19d
@Mygod
Copy link
Contributor Author

Mygod commented Jul 12, 2016

@Chainfire Fixed. Thanks for pointing that out.

Chainfire added a commit that referenced this issue Aug 24, 2016
@Chainfire
Merge pull request #56 from Mygod/master
64c635e 
Fix #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dschuermann @Chainfire @Mygod