Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorter protocol id #3906

Merged
merged 1 commit into from Aug 29, 2023
Merged

feat: shorter protocol id #3906

merged 1 commit into from Aug 29, 2023

Conversation

dandanlen
Copy link
Collaborator

The protocol id was needlessly long

@dandanlen dandanlen requested a review from ahasna August 28, 2023 17:14
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #3906 (453ef2d) into main (cad228d) will increase coverage by 0%.
Report is 4 commits behind head on main.
The diff coverage is 0%.

@@          Coverage Diff           @@
##            main   #3906    +/-   ##
======================================
  Coverage     71%     71%            
======================================
  Files        364     366     +2     
  Lines      56218   56762   +544     
  Branches   56218   56762   +544     
======================================
+ Hits       39998   40535   +537     
+ Misses     14257   14215    -42     
- Partials    1963    2012    +49     
Files Changed Coverage Δ
state-chain/node/src/chain_spec.rs 1% <0%> (ø)

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen merged commit f9b6e4c into main Aug 29, 2023
42 checks passed
@dandanlen dandanlen deleted the fix/shorter-protocol-id branch August 29, 2023 07:51
syan095 added a commit that referenced this pull request Aug 29, 2023
…on-integration

* origin/main:
  fix: is_qualified should be called for all checks (#3910)
  🍒 cherry-pick: `preinst` script updates (#3917)
  Chore: explicitly reset vault rotator state on ceremony restarts (#3907)
  feat: shorter protocol id (#3906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants