fix: use percentage for eth fee history #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4071 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 376 376
Lines 59662 59667 +5
Branches 59662 59667 +5
=====================================
+ Hits 42561 42563 +2
Misses 14958 14958
- Partials 2143 2146 +3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -272,7 +272,7 @@ mod tests { | |||
| println!("{:?}", block_with_txs); | |||
|
|
|||
| let fee_history = client | |||
| .fee_history(10.into(), BlockNumber::Latest, &[0.1, 0.5, 0.9]) | |||
There was a problem hiding this comment.
Was this always wrong or is this related to mainnet?
There was a problem hiding this comment.
probably was always wrong, but we only detected it when running against real Ethereum
There was a problem hiding this comment.
yeah think it's always been wrong
kylezs
approved these changes
Oct 9, 2023
AlastairHolmes
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fee history calculation. Cherry pick from kitkat.